Add proper json mapping for Trigger by jonnybbb · Pull Request #677 · cloudbees-oss/zendesk-java-client
The trigger category isn't properly handled as the JsonProperty annotation is missing for this camel case property name
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, thanks for the fix!
Marking as breaking since a Trigger persisted with a previous version will lose those two fields when deserialised.
I saw that a test is failing, I'll try to have a look.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters