Normalize "stitch mode" Usage by Hamms · Pull Request #71593 · code-dot-org/code-dot-org
We currently offer developers the ability to specify using stitch mode "none" when invoking the I see no difference step of Eyes tests, which will disable full-page screenshots in favor of only inspecting the current viewport. This is a bit of a holdover from when we used to allow developers to actually specify the stitch mode they wanted to use, before we standardized on css stitching.
Additionally, the current prevalence of these stitch mode invocations is itself a holdover from when Applab used to exhibit strange behavior in stitch mode. I'm not sure what changed such that Applab now works just fine in stitch mode, but it turns out that the vast majority of our current uses are no longer necessary!
This PR addresses both of those oddities. The two remaining places in the codebase where we do still want to inspect only the current viewport can now do so by specifying in the current viewport rather than using stitch mode "none", and all other uses have been removed.
bundle exec ./runner.rb --html --eyes --auto_retry -c Chrome -f features/eyes.feature,features/initial_page_views2.feature,features/javalab/code_review_scenarios.feature,features/javalab/console_only.feature,features/javalab/javalab_demo_mode.feature,features/javalab/neighborhood.feature,features/javalab/prompter.feature,features/javalab/theater.feature,features/platform/one_trust.feature,features/star_labs/applab/eyes1.feature,features/star_labs/applab/eyes2.feature,features/star_labs/applab/eyes3.feature,features/star_labs/applab/eyes4.feature,features/star_labs/applab/tooltips.feature,features/star_labs/gamelab/eyes.feature,features/teacher_tools/below_visualization.feature,features/teacher_tools/instructions/hoc_top_instructions.feature,features/teacher_tools/level_types/free_response_contained_levels.feature,features/teacher_tools/level_types/multiple_choice_contained_levels.feature,features/teacher_tools/teacher_student_toggle.feature --parallel 20
I will plan to coordinate with the DOTD when deploying this, just in case despite my testing this does require us to update some baselines