Home Original page

NIO-7: Potential performance gains using offloading by mkarg · Pull Request #91 · codehaus-plexus/plexus-utils

@mkarg

This PR proposed the use of NIO-7 functionality to benefit from potential performance gains thanks to offloading to lower levels (JVM-internal solutions, OS-internal solutions, FS-internal solutions, etc.) instead of old-school File API.

Provides potentially better performance.

Signed-off-by: Markus KARG <markus@headcrashing.eu>
Provides potentially better performance.

Signed-off-by: Markus KARG <markus@headcrashing.eu>

@mkarg

bimargulies

michael-o

michael-o

olamy

@mkarg

What do I have to do to trigger merging?

@mkarg

michael-o

@mkarg

@michael-o Thank you for the additional approval, but what is the process for actually merging the PR?

@michael-o

Pushing the merge button.

@mkarg

Pushing the merge button.

The button is not enabled for me. Seems I am missing the needed rights. What do I have to do to obtain them for the next time?

@michael-o

Pushing the merge button.

The button is not enabled for me. Seems I am missing the needed rights. What do I have to do to obtain them for the next time?

I was referring to myself or other project committers ;-)

@mkarg

Pushing the merge button.

The button is not enabled for me. Seems I am missing the needed rights. What do I have to do to obtain them for the next time?

I was referring to myself or other project committers ;-)

How can I become a committer? I always wait for months for reactions upon my PRs, and I would like to be a more agile member of the team.

@michael-o

I will try to add you. I have been contributing anyway in the last couple of years. But even if you are a committer we still prefer PRs for peer reviews.

@mkarg

I will try to add you. I have been contributing anyway in the last couple of years. But even if you are a committer we still prefer PRs for peer reviews.

Thanks for adding me. Sure I will still file PRs for reviews, but in the end I can click merge three months earlier. ;-)