fix: set content-primary text color instead of hardcoding white text by aqandrew · Pull Request #21908 · coder/coder
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Reviewed the migration from hardcoded text-white to semantic text-content-primary token. The changes are well-structured and address the issue correctly. Found 1 minor spacing inconsistency.
Summary
- ✅ All 4 instances of
.text-whiteproperly replaced withtext-content-primary - ✅ Changes verified in Storybook stories
- ✅ Follows Tailwind best practice of using semantic color tokens
- ⚠️ One minor formatting inconsistency with double spaces
Testing
Good job verifying the changes in Storybook. The affected components (Markdown GFM alerts, TaskPrompt external auth, UserGroupsCell tooltips, and Workspace notifications) should all now properly respect the theme's primary content color.