chore: replace Inter with Geist variable font by jaaydenh · Pull Request #22060 · coder/coder
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the font in Coder Kit as well and suggest we make some slight adjustments to the weights
text-base: Geist Regular (before Inter Medium)
text-sm: Geist Regular (before Inter Medium)
text-xs: Geist Regular (before Inter Medium)
text-xs mono: Geist Medium (before DM mono regular)
Regular is 400, Medium 500 I think
@chrifro currently whether something is regular, medium, bold etc, is currently set directly in the component and is also not 100% consistent for xs, sm, base. Are you suggesting we make sure all usages of text-xs, text-sm, text-base and text-xs mono, always have the same weights? This may be a separate PR.
@chrifro currently whether something is regular, medium, bold etc, is currently set directly in the component and is also not 100% consistent for xs, sm, base. Are you suggesting we make sure all usages of text-xs, text-sm, text-base and text-xs mono, always have the same weights? This may be a separate PR.
Ah interesting. Okay that would be a different PR then. Wouldn't it be a lot more intuitive if the weights are pre-defined and are not a guessing game? text-xs, text-sm, text-base need to exist in semi-bold for headlines and regular for standard text
@chrifro I actually made a change to make the font weight consistent in this PR, a separate PR will still be needed to clean up to redundant usages of font weight throughout the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters