Home Original page

Move to .NET Standard 2.0 by ViktorHofer · Pull Request #307 · commandlineparser/commandline

I did git clone to the project and merged the branch 'ViktorHofer-netstandard20' on my machine.

in vs2017.8
The compilation is successful
The unit test is successful for total 326 unit test cases.

I tested the project for multi-target (net45 and netstandard2.0) and compilation/unit test pass successfully.

The Conflicting files:

The file: 'tests/CommandLine.Tests/CommandLine.Tests.csproj': no problem because it's the old project file.
The file 'tests/CommandLine.Tests/Unit/Core/InstanceBuilderTests.cs' is expected because there are many modification due to the breaking change of FluentAssertions library version "5.4.1" (full support for netstandard2.0)

For example, the line#127

       ((NotParsed<Options_With_Required_Set_To_True>)result).Errors.ShouldBeEquivalentTo(expectedResult);

is modified by ViktorHofer to

        ((NotParsed<Options_With_Required_Set_To_True>)result).Errors.Should().BeEquivalentTo(expectedResult);

So I suggest merging 'ViktorHofer-netstandard20' branch, resolving the confliction based on the above notes and select (theirs) of ViktorHofer modifications.

The auto generated package v3.0.0:

<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
	<id>CommandLineParser</id>
	<version>3.0.0</version>
	<title>Command Line Parser Library</title>
	<authors>gsscoder,nemec,ericnewton76</authors>
	<owners>gsscoder,nemec,ericnewton76</owners>
	<requireLicenseAcceptance>false</requireLicenseAcceptance>
	<licenseUrl>https://raw.githubusercontent.com/gsscoder/commandline/master/doc/LICENSE</licenseUrl>
	<projectUrl>https://github.com/gsscoder/commandline</projectUrl>
	<iconUrl>https://raw.githubusercontent.com/commandlineparser/commandline/master/art/CommandLine20.png</iconUrl>
	<description>Terse syntax C# command line parser for .NET.  For FSharp support see CommandLineParser.FSharp.  The Command Line Parser Library offers to CLR applications a clean and concise API for manipulating command line arguments and related tasks.</description>
	<copyright>Copyright (c) 2005 - 2018 Giacomo Stelluti Scala &amp; Contributors</copyright>
	<tags>command line commandline argument option parser parsing library syntax shell</tags>
	<dependencies>
	  <group targetFramework=".NETFramework4.5" />
	  <group targetFramework=".NETStandard2.0" />
	</dependencies>
  </metadata>
</package>