add support for net40 and net45 by moh-hassan · Pull Request #387 · commandlineparser/commandline
@ericnewton76
To check that all tests pass in both net461 and netcoreapp2.0, I modified the Test Project as multi-target project:
<TargetFrameworks>net461;netcoreapp2.0</TargetFrameworks>
I run dotnet test and find 14 test fail in net461 due to the reasons we discussed in the issue-389
I fixed the failed test by using the solution I explained in the same issue
All tests pass Successfully in both net461 and netcoreapp2.0
The PR support: net40,net45,net461,netstandard2.0,netcoreapp2.0 and Fsharp fix is included.
The test pass in CI Appveyor
with the green success text:
NET461
Test run for C:\projects\commandline\tests\CommandLine.Tests\bin\Debug\net461\CommandLine.Tests.dll(.NETFramework,Version=v4.6.1)
....
Total tests: 335. Passed: 335. Failed: 0. Skipped: 0.
Test Run Successful.
NETCoreApp2.0
Test run for C:\projects\commandline\tests\CommandLine.Tests\bin\Debug\netcoreapp2.0\CommandLine.Tests.dll(.NETCoreApp,Version=v2.0
...
Total tests: 335. Passed: 335. Failed: 0. Skipped: 0.
Test Run Successful.
The confliction in the merge is:
<<<<<<< master
<TargetFrameworks>netstandard2.0;net40;net45;net461;netcoreapp2.0</TargetFrameworks>
=======
<TargetFrameworks>netstandard2.0; net461; netcoreapp2.0</TargetFrameworks>
>>>>>>> master
which can be resolved manually
Let me know if i missed something to do.