Home Original page

Fix detailed error codes on Windows by bergerst · Pull Request #911 · databus23/helm-diff

@bergerst

Switches from Powershell to calling the diff.exe directly since Powershell hides the original exit code.

Fixes #910

Tested locally by editing the plugin.yaml in the plugin directory.

Switches from Powershell to cmd since Powershell hides the original exit code.

@bergerst

@bergerst

Oh, also: the documentation doesn't state anywhere that you need to install Powershell (pwsh.exe) instead of using "Microsoft Powershell" (powershell.exe).

Not sure how to best express this in the README.

Just switching the install and upgrade commands from pwsh to powershell is not an option without rewriting the install and upgrade scripts to Microsoft Powershell. So I would suggest not touching that part.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Windows-specific bug where the --detailed-exitcode flag was not returning the correct exit code (2) when changes are detected. The issue was caused by PowerShell wrapping the binary execution, which transforms all non-zero exit codes to 1.

Changes:

  • Removed Windows-specific PowerShell wrapper from platformCommand in plugin.yaml, allowing direct binary execution that preserves exit codes