add dependencies from grease configuration to compileOnly by 0xera · Pull Request #13 · deepmedia/Grease

@0xera

@0xera

@natario1

Were you able to reproduce #11? As I remember using compileClasspath already makes compilation work. And compileOnly creates problem downstream because it adds the dependency to the POM. I think we should have a reproducer for #11 first

@0xera

@0xera

No, i could not reproduce #11. Also author says first crash does not happen anymore

@0xera

I have found why there is a problem with META-INF. It is because shadow jar uses Gradle Api from 8.3 version, so building a library with lower version than 8.3 will led to the crash. We could write about these limitations in the README

Снимок экрана 2024-09-29 в 12 50 36
Снимок экрана 2024-09-29 в 12 50 46

@0xera

@0xera

Hi, @natario1 I have added a functional test and you can run it to make sure that compileOnly dependencies are not in a pom file

natario1

@natario1

@0xera I approved it, my doubt is whether this really fixes anything. compileClasspath always worked well regarding adding deps to the compilation classpath, so if it works we shouldn't change it. But feel free to merge if you reproduced issues with compileClasspath that are solved by compileOnly.