Add License, Workflows, Publication tasks, README, v0.4.0 by natario1 · Pull Request #3 · deepmedia/Grease
Hey @0xera , I have two questions.
- There's a bug in RClassRelocator, it's picking up all classes starting with R. Do you know how to change the regex? I don't want to miss any edge case.
- Regarding
greasevsgreaseApi, wouldn't it be better to only havegrease(transitive) and if people don't want transitive behavior, they change it on the dep level using proper gradle API?
dependencies {
grease("mydep:1.0.0") {
isTransitive = false // or exclude(...)
}
}grease vs. greaseApi is hard to understand, it took me a while. And while they do a good job for Android apps, they probably don't work properly for Android libraries (in terms of dependencies that end up listed in the POM file).
I'm thinking isTransitive = false at the dep level is already what we need. In a future release we may improve this by ensuring that when isTransitive = false is used, transitive dependencies are also added as implementation.