Publish to Central Portal by Goooler · Pull Request #2539 · diffplug/spotless
Comment on lines -35 to +36
| ORG_GRADLE_PROJECT_nexus_user: ${{ secrets.NEXUS_USER }} | ||
| ORG_GRADLE_PROJECT_nexus_pass64: ${{ secrets.NEXUS_PASS64 }} | ||
| ORG_GRADLE_PROJECT_central_portal_user: ${{ secrets.CENTRAL_PORTAL_USER }} | ||
| ORG_GRADLE_PROJECT_central_portal_pass64: ${{ secrets.CENTRAL_PORTAL_PASS64 }} |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worthwhile to add new secrets and remove the old ones to clearly distinguish between them.
e.g. GradleUp/shadow#1414.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are correct that this is the good thing to do. But because DiffPlug has a central repository where all the rest of our builds pull from
it saves me a bit of time to keep the old names. Just FYI, I reverted to the old cred names (with updated values) in the commit referenced at the bottom of this PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with either.