Support for build-args of docker build by alenkacz · Pull Request #410

Support for build-args of docker build by alenkacz · Pull Request #410 · docker-java/docker-java

In 1.9 there is new property - build-args that can be specified for
docker build command

In 1.9 there is new property - build-args that can be specified for
docker build command

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since what API version?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 1.21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. 1.21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add javadoc? Example:


	/**
	* See {@link #oomKilled}
	*/
	@CheckForNull

and reference to field

	/**
	* @since {@link RemoteApiVersion#VERSION_1_17}
	*/
	@CheckForNull

I have added javadoc with api version information

@alenkacz @KostyaSha I'm OK with it but it needs to be implemented/tested for the netty based BuildImageCmdExec also before this PR can be merged.

I have added that netty based implementation. By the way - keeping two implementations like this is not a good architectural decision - I think. It is really error prone...

Also I think that you should detach this forked repository if you are not planning on merging it back to the previous one. Because if it is like this, contributions are not counted for example - because they are counted only after fork is merged to the original repository. Which will never happen.

How to detach fork is written here - https://www.quora.com/Git-revision-control/How-can-one-detach-a-forked-project-in-GitHub I used GitHub support in the past and they are really quick.

@alenkacz Thanks! The netty implementation will supersede the old jersey implementation in the near future so this is a temporary situation only that will stay until after the next release ( > v3.0.0).

I will try to reach Github support to detach the repository as you suggested. Didn't know this is possible.

Will merge this ASAP. Thanks for contributing!

Also I think that you should detach this forked repository if you are not planning on merging it back to the previous one. Because if it is like this, contributions are not counted for example - because they are counted only after fork is merged to the original repository. Which will never happen.

Fork shows history, initial repository is not used anymore and technically i think it in mergeable state.

@marcuslinke does this fork changed artifactId? If not then i see no reasons for breaking fork chain.

@KostyaSha The groupId was changed from com.kpelykh to com.github.docker-java. However, beside this I see one main reason to detach: When you create a pull request the default base fork is set to https://github.com/kpelykh/docker-java which annoys me everytime. So do you have any objections against detaching?