Fix auto-scroll undershooting correction location on initial page load by nrankin18 · Pull Request #2237 · docsifyjs/docsify
Summary
Bug: Navigating to an anchor link on docs with images causes the initial auto-scroll to "undershoot" the correct location. This is because the scroll location is calculated prior to the images loading, so the image heights aren't accounted for in the location calculation.
Fix: Replace Tweezer animation with scrollIntoView which adjusts for image heights.
Additional Bug: Auto-scroll on an initial page load does not scroll the appropriate sidebar element into view. This is because the #highlight function was blocked while the Tweezer animation was running.
Fix: Delay the #highlight function from running until scrollIntoView has finished.
Related issue, if any:
What kind of change does this PR introduce?
Bugfix
For any code change,
- Related documentation has been updated, if needed
- Related tests have been added or updated, if needed
Does this PR introduce a breaking change?
No
Tested in the following browsers:
- Chrome
- Firefox
- Safari
- Edge