Home Original page

Show description or tooltip on boolean controls by brockfanning · Pull Request #2072 · eclipsesource/jsonforms

Conversation

@brockfanning

The intended behavior here is that if a boolean control has a description, then it will appear as a tooltip. However if showUnfocusedDescription is true, then the description appears below as text. I tried to copy as much code from existing components as possible, but I'm happy to make any changes as needed.

@netlify

@CLAassistant

CLA assistant check
All committers have signed the CLA.

@coveralls

Coverage Status

Coverage: 83.193%. Remained the same when pulling d292be4 on brockfanning:mui-checkbox-with-description into 3b32c9b on eclipsesource:master.

lucas-koehler

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @brockfanning, thank you very much for your contribution :)
I tested it and it seems to work well.

I have two requests:

  1. Could you extend one the examples to contain a description for the boolean control. E.g. you could extend packages/examples/src/examples/control-options.ts
  2. Could you also add this behavior to the MaterialBooleanToggleControl as well? This way both boolean controls behave consistently.

lucas-koehler

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates and again for the contribution :)
CI did not run again due to a first time contributor. However, I executed the build and unit tests locally and they still worked :)

Labels