translate array controls in material renderers by LukasBoll · Pull Request #2099 · eclipsesource/jsonforms
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LukasBoll , thanks for your pull request :)
I like the general approach of making the array translations available in a typed way.
Please have a look at the inline comments. They are mainly about namings to make things more clear.
Also, testing that translations are properly applied is pretty inconvenient right now. I suggest adding an additional example similar to packages/examples/src/examples/arrays.ts.
The new example could be named Array (i18n)
You can leave out the non-array property and probably do not need the actions to toggle sorting. Instead, the sorting buttons should be shown in the new example to allow checking their aria labels.