Home Original page

Add Object and OneOf renderer to vue3-vanilla by butzist · Pull Request #2151 · eclipsesource/jsonforms

@butzist

We ported the Object and OneOf renderers from vue2 to vue3 - would be nice to have them upstream

@netlify

@CLAassistant

CLA assistant check
All committers have signed the CLA.

@sdirix

Thanks for the contribution ❤️

In general we are definitely interested in these renderers 👍 . Please make sure that the build succeeds (there seem to be some Typescript errors) and sign the CLA. Afterwards we'll take a look. Thanks!

@coveralls

Coverage Status

coverage: 84.254%. remained the same when pulling 356347b on DataHow:feat/vue3-vanilla-object-and-oneof-renderer into 7e0115f on eclipsesource:master.

@butzist

Update: added some tests for the new renderers, but was not able to test the dialog in the OneOfRenderer (showModal() is not a function). It worked in manual testing though. Let me know if there is anything missing.

sdirix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general! Can you take a look at my comments?

@butzist

@sdirix Thank you for the review. I tried to adress them as good as I can and also fixed linting.

@butzist

Now also the build is passing for me - sorry for the inconvenience, but had some trouble getting the build system to work locally

@butzist

LukasBoll

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great contribution @butzist!
Everything looks good to me. I just found one issue, which I addressed in my comment below.

@butzist

LukasBoll

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

sdirix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you again for the contribution! ❤️