update peer dependency for mui/icons in material-renderers by IhsenBen · Pull Request #2186

update peer dependency for mui/icons in material-renderers by IhsenBen · Pull Request #2186 · eclipsesource/jsonforms

self explanatory minor change

All committers have signed the CLA.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution ❤️
I added a comment inline. Please have a look.

		"@jsonforms/core": "3.1.1-alpha.0",
		"@jsonforms/react": "3.1.1-alpha.0",
		"@mui/icons-material": "~5.11.16",
		"@mui/icons-material": ">=5.11.16",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= seems a bit too lax to me because it also allows all higher major versions (e.g. 6.x, 7.x). I think we should change it to ^5.11.16 to allow all 5.x versions but no other major versions. If it's known to work with 6.x it could then be adapted to ^5.11.16 || ^6.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done :D

coverage: 83.924% (-0.5%) from 84.469% when pulling cac6fd5 on IhsenBen:bug-fix/renderers-peerPkg-version into 28eeeca on eclipsesource:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @IhsenBen ,
I changed it to ^5.11.16 because v6 does not exist yet and we don't know whether it will be compatible. Thanks for the issue and the PR :)

Hi @IhsenBen , I changed it to ^5.11.16 because v6 does not exist yet and we don't know whether it will be compatible. Thanks for the issue and the PR :)

no problem, thx for your reactivity.
have a nice day