fix(material): Resolve refs in object renderer by LukasBoll · Pull Request #2202

fix(material): Resolve refs in object renderer by LukasBoll · Pull Request #2202 · eclipsesource/jsonforms

Conversation

Previously, UI schemas generated in the Material object renderer were incomplete because not all refs could be resolved.

Closes #2187

coverage: 84.469%. remained the same
when pulling 0f1fc78 on LukasBoll:fix/resolve_ref_in_object_renderer
into f905c82 on eclipsesource:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you also check all other invocations of Generate.uiSchema in the code base? We are missing the extra parameters in multiple places.

Previously, UI schemas generated by JsonForms were incomplete in many instances
because not all references were resolved. This commit addresses the issue by
providing the root schema to all usages of the Generate.uischema function,
ensuring the resolution of all references.

Closes eclipsesource#2187

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM