Vanilla TextCell password by adammation · Pull Request #2249

Vanilla TextCell password by adammation · Pull Request #2249 · eclipsesource/jsonforms

For vanilla-renderers TextCell, use "type" option to select an alternative HTML5 input type such as "email" or "password"

All committers have signed the CLA.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the contribution ❤️

In the React Material UI renderers we already support format: 'password' as the indicator to render a password field. Would this work for you too? I would prefer to be consistent between renderer sets.

coverage: 84.798%. remained the same
when pulling 550fe09 on adammation:vanilla-textcell-password
into fce6b1e on eclipsesource:master.

Hi! Thanks for the contribution ❤️

In the React Material UI renderers we already support format: 'password' as the indicator to render a password field. Would this work for you too? I would prefer to be consistent between renderer sets.

Sounds great, changed to format: "password"

Comment on lines +53 to +55

		type={
		appliedUiSchemaOptions.format ? appliedUiSchemaOptions.format : 'text'
		}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	type={
	appliedUiSchemaOptions.format ? appliedUiSchemaOptions.format : 'text'
	}
	type={appliedUiSchemaOptions.format === 'password' ? 'password' : 'text'}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer only passing through the password as in React Material. Other types might be incompatible. I would have applied the change myself but maintainer editing was turned off for this PR

Closed in favor of #2254. Thanks for the contribution ❤️