refactor(core): resolve circular dependencies by LukasBoll · Pull Request #2345

refactor(core): resolve circular dependencies by LukasBoll · Pull Request #2345 · eclipsesource/jsonforms

Eliminated circular dependencies in the core module and reorganized package structure.

coverage: 83.269% (-0.07%) from 83.337%
when pulling 0b6758f on LukasBoll:resolve_dependencies
into c00b664 on eclipsesource:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LukasBoll , thanks for the PR ❤️
The changes already look mostly good to me and no more circular dependency warnings are shown :)
Besides two inline comments, I suggest renaming the folder stateToPropsMapper to simply mappers: Not all of the methods are mapping state to props but most of them map either state or dispatch to some kind of props or utility data structure.

Eliminated circular dependencies in the core module and reorganized package structure.

Ref eclipsesource#2321

coverage: 83.26% (-0.08%) from 83.337%
when pulling 2dc1e47 on LukasBoll:resolve_dependencies
into c3cead7 on eclipsesource:master.

Hi @LukasBoll , thanks for the PR ❤️ The changes already look mostly good to me and no more circular dependency warnings are shown :) Besides two inline comments, I suggest renaming the folder stateToPropsMapper to simply mappers: Not all of the methods are mapping state to props but most of them map either state or dispatch to some kind of props or utility data structure.