Add support for "multiple" prop on Select (fixes #2347) by jchamberlain · Pull Request #2356

Add support for "multiple" prop on Select (fixes #2347) by jchamberlain · Pull Request #2356 · eclipsesource/jsonforms

Here are the changes proposed in #2347.

All committers have signed the CLA.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jchamberlain , thanks for the contribution ❤️
The changes LGTM. Could you pleaserebase them onto the current master to get a (hopefully) clean run of the CI? Thanks!

@jchamberlain I rebased the changes with Github's builtin functionality. The lint check fails because MuiSelect is not formatted properly. Please apply the formatting accordingly :)

coverage: 83.265%. remained the same
when pulling 7685c7d on jchamberlain:support-multiple-select
into d3ee13a on eclipsesource:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks again for the contribution :)

Thanks, @lucas-koehler! I was going to start using it in my project directly via the master branch, but my ancient version of yarn doesn't like your monorepo (and I can't upgrade yarn just yet). How soon will you be publishing a new release tag? Anything that publishes the individual packages to NPM will work for me. Perhaps you could publish an alpha or beta?