fix(material-renderers): add missing Mui-error class for some controls by vishnutsivan · Pull Request #2433

fix(material-renderers): add missing Mui-error class for some controls by vishnutsivan · Pull Request #2433 · eclipsesource/jsonforms

Passing error prop for missing controls

All committers have signed the CLA.

coverage: 82.517%. remained the same
when pulling 9f53777 on vishnutsivan:master
into 9acd631 on eclipsesource:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution aligning this with the other controls ❤️

Please remove the version update as explained inline :)

		{
		"name": "@jsonforms/material-renderers",
		"version": "3.5.1",
		"version": "3.5.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this. Version numbers are automatically increased when we release a new version via CI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted. when can we expect new version?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnutsivan Thanks for the update! This LGTM now.

The next regular release will probably be around end of May or in June. There is no fixed date, yet. However, we could do a pre-release (e.g. 3.6.0-alpha.0) this week.