refactor(material-renderers): remove deprecated prop by johannesss · Pull Request #2437 · eclipsesource/jsonforms
remove deprecated prop button of ListItem and use ListItemButton instead.
fixes #2426
Hi @johannesss , thanks for the contribution ❤️
The change itself looks good but is missing adapting the tests in MaterialListWithDetailRenderer.test.tsx as they still check for presence of ListItems. Please adapt them, too :)
Hi @johannesss , thanks for the contribution ❤️ The change itself looks good but is missing adapting the tests in
MaterialListWithDetailRenderer.test.tsxas they still check for presence ofListItems. Please adapt them, too :)
Ohhh, okay! Will do!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Thanks for the contribution and the updates!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters