refactor(material-renderers): remove deprecated prop by johannesss · Pull Request #2437 · eclipsesource/jsonforms

@johannesss

remove deprecated prop button of ListItem and use ListItemButton instead.

fixes #2426

@johannesss

@netlify

@lucas-koehler

Hi @johannesss , thanks for the contribution ❤️
The change itself looks good but is missing adapting the tests in MaterialListWithDetailRenderer.test.tsx as they still check for presence of ListItems. Please adapt them, too :)

@johannesss

Hi @johannesss , thanks for the contribution ❤️ The change itself looks good but is missing adapting the tests in MaterialListWithDetailRenderer.test.tsx as they still check for presence of ListItems. Please adapt them, too :)

Ohhh, okay! Will do!

@johannesss

@johannesss

@coveralls

Coverage Status

coverage: 82.517%. remained the same
when pulling 44ddfc7 on johannesss:fix/material-deprecated-prop
into 9a60420 on eclipsesource:master.

lucas-koehler

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks for the contribution and the updates!