Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way to save code for those left with 512KB flash!, while preserving the use of library code.

Other than the #if comment from @devyte, LGTM.

@d-a-v Thx!, The PR eliminates the firmware size increase. :-)
Yes, we do use compressed and uncompressed OTA. Both works like a charm!

I was asking about OTA because I have been thinking that increased size on one side would be compensated by size decrease on the other (thanks to compressed OTA). But as @earlephilhower noted, there are still 512K flash chips around, these ones could use any flash size optimization.