CI waveform flavour select by d-a-v · Pull Request #7715 · esp8266/Arduino
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the log dump is removed.
| print_size_info >size.log | ||
| export ARDUINO_IDE_PATH=$arduino | ||
| local pwm_phase="" | ||
| [ $(( $build_rem % 2 )) -eq 0 ] && local pwm_phase="--waveform_phase" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bash is a monster, isn't it? I was about to make a comment that you wanted == but then realized you're generating local.
Not sure if the local here is needed since you already made one on the prior line.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the second local