WString: return bool instead of unsigned char by mcspr · Pull Request #7939 · esp8266/Arduino

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I really like the idea, @mcspr !

That said, I'm worried about changing the signature of something as basic as String. Even today, in the ArduinoAPI repo String.h uses unsigned char. So this change would move our interface away from that, and break anything inheriting from String.
https://github.com/earlephilhower/ArduinoCore-API/blob/9da53735171f7cccbe781c66d9ee1068d94d6ec8/api/String.h

So I'm honestly not sure which way to go here. Let's discuss and see if we can get anyone else's input.