add comments and corrections by mhightower83 · Pull Request #8201 · esp8266/Arduino
Added conditional build around option 'p' to call stack_thunk_dump_stack which can only print when debug is enabled.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the ROM disassembly, it does seem that there is no UART param in ets_install_uart_printf, so LGTM. Thx!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters