Home Original page

:sparkles: NEW: Emits sphinx include-read event by sumezulike · Pull Request #887 · executablebooks/MyST-Parser

Conversation

@sumezulike

Adds emission of Sphinx include-read events while processing include directives, closes #881.

include-read

If there is a better way to restrict the test to Sphinx>=7.5.2, please let me know.

@welcome

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

…thon 3.12

Also added test for included files that are not inside the source directory

@sumezulike

Sorry about the noise, I forgot to test against older Python versions. Grateful for any feedback!

@chrisjsewell

cheers will have a look soon

@sumezulike

Any chance to take a look yet?

@codecov-commenter

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (da1a85a) to head (d0bddee).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   90.10%   90.12%   +0.01%     
==========================================
  Files          24       24              
  Lines        3377     3383       +6     
==========================================
+ Hits         3043     3049       +6     
  Misses        334      334
Flag Coverage Δ
pytests 90.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell

If there is a better way to restrict the test to Sphinx>=7.5.2, please let me know.

sorted

chrisjsewell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good thanks!

@welcome

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@sumezulike