feat: add support for MFA challenge during sign in by Lyokone · Pull Request #2248 · firebase/FirebaseUI-Android
Add support for MFA challenge during sign in.
Will catch the error and update internal state appropriately.
| onSuccess = { | ||
| pendingResolver.value = null | ||
| // Reset auth state to Idle so the firebaseAuthFlow Success state takes over | ||
| authUI.updateAuthState(AuthState.Idle) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be able to updateAuthState from outside FirebaseAuthUI class?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should allow that, either the user is using it properly, or not 🤔
Can be discussed in a future release
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters