feat(fcm): Support `apns.live_activity_token` field in FCM `ApnsConfig` by janodetzel · Pull Request #2891 · firebase/firebase-admin-node
- feat(fcm): Support
live_activity_tokenfield onApnsConfig - added validation
- update documentation
Fixes #2875
| }); | ||
| }); | ||
|
|
||
| const invalidApnsLiveActivityTokens: any[] = [null, NaN, 0, 1, true, false] |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we should add a test for valid payload?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I added the tests with valid payloads for the live activity start | update | end events
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Could you change the new property to lowerCamelCase formatting?
Can you also run npm run api-extractor:local? That would update the api docs and should fix the CI errors. Thanks!
* feat(fcm): Support `live_activity_token` field on `ApnsConfig` * added validation * update documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters