feat(auth): Allow enabling of anonymous provider via tenant configuration by rsgowman · Pull Request #802 · firebase/firebase-admin-node

@rsgowman

@rsgowman

hiranya911

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can you add a reference to the API proposal in the description.

bojeil-google

@google-cla

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rsgowman

Can you add a reference to the API proposal in the description.

Done.

@google-cla

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@dgibney

Looks like this was almost over the line before the holidays hit. Hope this comment may bring it back on someone's radar. Thanks.

@rsgowman

Thanks for the reminder. I'll get this in front of the appropriate people this week, and we'll see if we can finish it up. (It had stalled due to some internal launch processes, but those were cleared up just before the holidays.)

hiranya911

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Just a couple of questions.

@rsgowman

@rsgowman

hiranya911

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsgowman

This was referenced

Jun 20, 2024

This was referenced

Jul 17, 2024

This was referenced

Jul 27, 2024

This was referenced

Aug 10, 2024

This was referenced

Aug 17, 2024

This was referenced

Aug 28, 2024

This was referenced

Sep 5, 2024

This was referenced

Sep 24, 2024

This was referenced

Oct 26, 2024