feat: Docker development environment by ojeytonwilliams · Pull Request #1337

feat: Docker development environment by ojeytonwilliams · Pull Request #1337 · freeCodeCamp/devdocs

Conversation

This should make it a little easier to get started as a new contributor, as well as cut out 'works on my machine' bugs.

@freeCodeCamp/devdocs let me know what you think. Does this all work as you expect?

		7. [Other contributions](#other-contributions)
		8. [Coding conventions](#coding-conventions)
		9. [Questions?](#questions)
		9. [Developing in Docker](#developing-in-docker)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section is missing in the file (has not been committed)?

		@@ -0,0 +1,2 @@
		USER_ID=1000
		GROUP_ID=1000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include a comment # for Dockerfile-dev?

		@@ -0,0 +1,13 @@
		version: '3.7'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have two Dockerfiles for running devdocs in production, I would not expect docker-compose.yml to be meant for development only.

		# a temporary directory to hold the lock files while the gems are installed.
		WORKDIR /devdocs/

		COPY Gemfile Gemfile.lock Rakefile /devdocs/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running docker build - < Dockerfile-dev failed:

Step 9/14 : COPY Gemfile Gemfile.lock Rakefile /devdocs/
COPY failed: stat /var/lib/docker/tmp/docker-builder202400793/Gemfile: no such file or directory

(Not exactly sure how it is meant to be used, though…)

Co-authored-by: Simon Legner <Simon.Legner@gmail.com>

Co-authored-by: Simon Legner <Simon.Legner@gmail.com>

Thanks for the review, Simon. The latest commits should have addressed all your concerns - including adding the missing docs (thanks reflog 😓). I also moved the environment variables into a sample.env, because I never should have added .env to git!

Hey @simon04, I'm still working on this. Right now using thor: upload doesn't work with AWS, so I need to figure it out.

@ojeytonwilliams and @simon04 Any updates on this? I can pick this up if you'd like. I cloned the repo and started making a devcontainer... and then realized you guys already started!

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels