Change Commit shortcut to ⌘+Return by danshevluk · Pull Request #845 · git-up/GitUp
OK, so after some research, it appears that there are a lot of places with the same behavior. Currently those are:
-> GIAdvancedCommitViewController.xib
- Commit
-> GICommitRewriterViewController.xib
- Rewrite Commit
-> GICommitSplitterViewController.xib
- Continue…
- Split Commit
-> GISimpleCommitViewController.xib
- Commit All Changes
I tried to find solutions to support both keyEquivalents, but could not find any easy options. There is a way to add an additional menuItem with the same actions but different key binding. This could work for some actions, but not as a whole-project solution.
If you agree that it's an important addition to GitUp, then there are two ways that we achieveachive that:
- Just change the shortcut in all mentioned places to
cmd+return. It's easy to do, but could break old shortcuts for lots of users ⚠️ - Move
keyEquivalentssetup to.mfiles from.xiband switch between option/cmd based no user preferences. For all new users it could be set tocmd, and to keep old users happy they will be able to opt-in in preferences, but not automatically.
Between these two options, I irrationally tend more to make a breaking change. The original way is strange and hard to discover without specifically looking into documentation.
How do you feel about these options?