add rocksdb as transactional engine by wangzihuacool · Pull Request #1190 · github/gh-ost
Related issue: #1189
Description:
Add support for rocksdb as transactional engine
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @wangzihuacool!
I've asked a question about the migration test changes in my review. Would you mind also adding PerconaServer-8.0.21 to the list of versions in .github/workflows/replica-tests.yml? I've merged github/gh-ost-ci-env#14, so we can enable the RocksDB migration tests in CI 😄
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangzihuacool thanks for your work on this PR 🙇. I've added a few comments in-line
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this introduced a regression: #1262
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters