fix: onSuccess hook to run after INSTANT by artemvovk · Pull Request #1463 · github/gh-ost

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: #1365

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR fixes that no hooks would run after a successful INSTANT DDL, which is an unexpected behavior.

kind of unclear on how to add tests for this because the migrator and hooks tests are very unrelated, but I can try

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.