Improve error messages by acuteenvy · Pull Request #2617 · gitui-org/gitui
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this. This clearly improves error handling. For a non-repo folder, we get / got:
For dubious ownership, the original cause here, we get / got /git says:
I'd almost argue that the new message is better than what git says. "Let's just ignore this security feature with this command" maybe is not soooo cool. ;)
I have to pick on one thing, though. The panic handler was there for a reason, as far as I can tell. See my remark below.

