cel_cc_embed: Open in file in binary mode · Pull Request #1443 · google/cel-cpp
Conversation
This is necessary on Windows; otherwise, newline conversion will corrupt the result.
Related issue: #768
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reasonable -- we will still have to apply the change internally and export, but I think we can make copybara a bit better about reporting you as the original author. No action needed on your part right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 participant