Home Original page

feat: Support roles field in SCIM by jalseth · Pull Request #3728 · google/go-github

@jalseth

GHES supports setting enterprise-wide role grants via the SCIM API. This can be used to grant enterprise owner, billing manager, etc.

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.12%. Comparing base (1b53270) to head (a8fe10b).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3728   +/-   ##
=======================================
  Coverage   91.11%   91.12%           
=======================================
  Files         187      187           
  Lines       16686    16686           
=======================================
+ Hits        15204    15205    +1     
+ Misses       1295     1294    -1     
  Partials      187      187

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jalseth 

GHES supports setting enterprise-wide role grants via the SCIM API. This can
be used to grant enterprise owner, billing manager, etc.

Signed-off-by: James Alseth <jalseth@google.com>

gmlewis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jalseth!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell and/or @alexandear, might you have time for a code review? Thank you!

stevehipwell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis