feat: Add fork PR workflows permission API support by zyfy29 · Pull Request #3737 · google/go-github
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.38%. Comparing base (22f34ec) to head (1835972).
⚠️ Report is 8 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #3737 +/- ## ========================================== + Coverage 91.34% 91.38% +0.03% ========================================== Files 187 187 Lines 16702 16764 +62 ========================================== + Hits 15257 15319 +62 Misses 1257 1257 Partials 188 188
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @zyfy29 - thank you!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have missed this from the other PRs but I don't feel like the In<CONTEXT> suffix feels ergonomic. The context is significant to the API call (it's the first segment) so making it the least significant part of the function name just looks a bit off.
@zyfy29 - please fix the linter and test failures and push the changes to this PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters