Home Original page

refactor!: Adjust function names and field types for billing API by zyfy29 · Pull Request #3770 · google/go-github

@zyfy29

BREAKING CHANGE: Billing-related methods are renamed to <verb><scope><subject> pattern, and required fields are changed to value types

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.37%. Comparing base (da0feca) to head (7bdb54f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3770   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         187      187           
  Lines       16760    16760           
=======================================
  Hits        15315    15315           
  Misses       1257     1257           
  Partials      188      188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis

@zyfy29 - I'm not seeing any renamed methods in this PR. In fact, the description doesn't appear to match the PR. Can you please clarify?

zyfy29

@gmlewis

Sorry, @zyfy29 - GitHub UI was completely freaking out on me... it showed no changes whatsoever to any methods.
Now it is showing them. I don't know what happened.

gmlewis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexandear

@zyfy29

stevehipwell

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI the GitHub UI is all over the place, I suspect it's rendering for non-latest commits. A page refresh has generally fixed this.

alexandear

@gmlewis