test: Ensure Authorization is not set with empty token by alexandear · Pull Request #3790

test: Ensure Authorization is not set with empty token by alexandear · Pull Request #3790 · google/go-github

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you, @alexandear!
LGTM.
Merging.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (b755d64) to head (a3e8195).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3790   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         191      191           
  Lines       13690    13690           
=======================================
  Hits        12619    12619           
  Misses        883      883           
  Partials      188      188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Sorry as a drive-by person without Google credits to burn, trying to design this was outside scope. I really appreciate that my baseline PR was merged and you wrote a follow up to add tests. (I'm currently smarting because some other company closed a PR of mine to fix a clear regression of theirs because they decided the problem scope was too complicated to let externals work on.)