Home Original page

chore: Update golangci-lint to v2.7.0 by stevehipwell · Pull Request #3853 · google/go-github

@stevehipwell

This PR fixes the currently broken golangci-lint custom plugin implementation (broken due to the GitHub Actions Git version). It also makes an auto-fix change that otherwise fails the linter.

@stevehipwell 

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>

alexandear

gmlewis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.46%. Comparing base (e279f70) to head (44db530).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3853   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         199      199           
  Lines       14240    14240           
=======================================
  Hits        13167    13167           
  Misses        884      884           
  Partials      189      189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alexandear

Comment on lines +99 to +100

if before, _, ok := strings.Cut(text, "</a>"); ok {
newText := before + strings.Join(innerText, "")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked correct to me, do you think it's wrong?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it breaks next time I use it, I'll revert the changes, so no big deal.