chore: Enable `govet` linter with all checks by alexandear · Pull Request #3935 · google/go-github

Conversation

@alexandear

This PR enables all govet checks except fieldalignment and shadow.

fieldalignment suggests rearranging fields to reduce struct size in memory, while shadow generates many warnings about shadowing local err variables.

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.44%. Comparing base (2936e40) to head (9d77589).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3935   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files         203      203           
  Lines       14961    14961           
=======================================
  Hits        13831    13831           
  Misses        927      927           
  Partials      203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 participants

@alexandear @gmlewis