Home Original page

fix!: Replace `UserListOptions.ListOptions` with `UserListOptions.PerPage` by Not-Dhananjay-Mishra · Pull Request #3977 · google/go-github

Conversation

@Not-Dhananjay-Mishra

BREAKING CHANGE: Replaced UserListOptions.ListOptions with UserListOptions.PerPage which will also result in removal of UsersService.ListAllIter

UsersService.ListAll don't have page acc to docs if you run ListAllIter it will go in infinite loop since its pagination is powered exclusively by the since parameter.

Related: #3976

Not-Dhananjay-Mishra

alexandear

alexandear

@alexandear

alexandear

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (c8fd3f7) to head (9d1f6b9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3977      +/-   ##
==========================================
- Coverage   93.53%   93.52%   -0.01%     
==========================================
  Files         207      207              
  Lines       17586    17569      -17     
==========================================
- Hits        16449    16432      -17     
  Misses        937      937              
  Partials      200      200

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.