feat: Add public wrapper for _mtls_helper.check_use_client_cert which… · googleapis/google-auth-library-python@1535ecc
@@ -643,7 +643,7 @@ def test_crypto_error(self):
643643def test_check_use_client_cert(self, monkeypatch):
644644monkeypatch.setenv("GOOGLE_API_USE_CLIENT_CERTIFICATE", "true")
645645use_client_cert = _mtls_helper.check_use_client_cert()
646-assert use_client_cert == "true"
646+assert use_client_cert is True
647647648648def test_check_use_client_cert_for_workload_with_config_file(self, monkeypatch):
649649config_data = {
@@ -663,19 +663,24 @@ def test_check_use_client_cert_for_workload_with_config_file(self, monkeypatch):
663663mock_file_handle = mock.mock_open(read_data=config_file_content)
664664with mock.patch("builtins.open", mock_file_handle):
665665use_client_cert = _mtls_helper.check_use_client_cert()
666-assert use_client_cert == "true"
666+assert use_client_cert is True
667667668668def test_check_use_client_cert_false(self, monkeypatch):
669669monkeypatch.setenv("GOOGLE_API_USE_CLIENT_CERTIFICATE", "false")
670670use_client_cert = _mtls_helper.check_use_client_cert()
671-assert use_client_cert == "false"
671+assert use_client_cert is False
672+673+def test_check_use_client_cert_unsupported_value(self, monkeypatch):
674+monkeypatch.setenv("GOOGLE_API_USE_CLIENT_CERTIFICATE", "dummy")
675+use_client_cert = _mtls_helper.check_use_client_cert()
676+assert use_client_cert is False
672677673678def test_check_use_client_cert_for_workload_with_config_file_not_found(
674679self, monkeypatch
675680 ):
676681monkeypatch.setenv("GOOGLE_API_USE_CLIENT_CERTIFICATE", "")
677682use_client_cert = _mtls_helper.check_use_client_cert()
678-assert use_client_cert == "false"
683+assert use_client_cert is False
679684680685def test_check_use_client_cert_for_workload_with_config_file_not_json(
681686self, monkeypatch
@@ -688,7 +693,7 @@ def test_check_use_client_cert_for_workload_with_config_file_not_json(
688693mock_file_handle = mock.mock_open(read_data=config_file_content)
689694with mock.patch("builtins.open", mock_file_handle):
690695use_client_cert = _mtls_helper.check_use_client_cert()
691-assert use_client_cert == "false"
696+assert use_client_cert is False
692697693698def test_check_use_client_cert_for_workload_with_config_file_no_workload(
694699self, monkeypatch
@@ -702,11 +707,11 @@ def test_check_use_client_cert_for_workload_with_config_file_no_workload(
702707mock_file_handle = mock.mock_open(read_data=config_file_content)
703708with mock.patch("builtins.open", mock_file_handle):
704709use_client_cert = _mtls_helper.check_use_client_cert()
705-assert use_client_cert == "false"
710+assert use_client_cert is False
706711707712def test_check_use_client_cert_when_file_does_not_exist(self, monkeypatch):
708713config_filename = "mock_certificate_config.json"
709714monkeypatch.setenv("GOOGLE_API_CERTIFICATE_CONFIG", config_filename)
710715monkeypatch.setenv("GOOGLE_API_USE_CLIENT_CERTIFICATE", "")
711716use_client_cert = _mtls_helper.check_use_client_cert()
712-assert use_client_cert == "false"
717+assert use_client_cert is False