feat(storage): Support read_all in the async client by shubham-up-47 · Pull Request #15303 · googleapis/google-cloud-cpp

Conversation

@shubham-up-47

The PR fixes issue: #15140 which says to provide a function to convert storage_experimental::AsyncReader into a single future<StatusOr<ReadPayload>>. The functionality is already there in storage_experimental::ReadAll() method.

This PR adds the method to a public header i.e. async client and updates the documentation.

This change is Reviewable

@codecov

Codecov Report

❌ Patch coverage is 99.08257% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.02%. Comparing base (c7d96c9) to head (7fd64bc).
⚠️ Report is 274 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/storage/async/client.cc 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15303      +/-   ##
==========================================
- Coverage   93.02%   93.02%   -0.01%     
==========================================
  Files        2403     2403              
  Lines      219424   219533     +109     
==========================================
+ Hits       204128   204228     +100     
- Misses      15296    15305       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shubham-up-47

1 similar comment

@shubham-up-47

devbww

@shubham-up-47

Labels

2 participants

@shubham-up-47 @devbww