Home Original page

feat(storage): Add samples related to AppendableObject and OpenObject by shubham-up-47 · Pull Request #15563 · googleapis/google-cloud-cpp

@shubham-up-47

This change is Reviewable

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (8689a95) to head (e0530c9).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15563      +/-   ##
==========================================
+ Coverage   93.05%   93.07%   +0.01%     
==========================================
  Files        2414     2414              
  Lines      221063   221114      +51     
==========================================
+ Hits       205720   205795      +75     
+ Misses      15343    15319      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shubham-up-47

@shubham-up-47

@shubham-up-47

@shubham-up-47

bajajneha27

futures.push_back(count_newlines(std::move(reader), std::move(token)));
}

// Wait for all futures and print results

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we should not be waiting for all the futures to be ready, we should just start reading the futures which are ready.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please re-check.

nidhiii-27

@shubham-up-47

@shubham-up-47

bajajneha27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just get alignment on region tags, rest everything looks good to me.

nidhiii-27

scotthart

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scotthart reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @bajajneha27)