perf(status): Remove MakeDefaultStatus() from Status move assignment … by andrewro-google · Pull Request #15566

perf(status): Remove MakeDefaultStatus() from Status move assignment … by andrewro-google · Pull Request #15566 · googleapis/google-cloud-cpp

Conversation

…and construction

It's a small perf hit but it does show up in profiles. In a long running query I see it taking 6% of the cpu time. I think the existing guarantee is stronger than it needs to be: generally no one should assume that a moved-from object has any invariants except it can be reinstantiated.

This change is

…and construction

It's a small perf hit but it does show up in profiles. In a long running query I see it taking 6% of the cpu time

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.04%. Comparing base (77ebc1e) to head (f14aac2).
⚠️ Report is 252 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15566   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files        2406     2406           
  Lines      219803   219797    -6     
=======================================
+ Hits       204518   204521    +3     
+ Misses      15285    15276    -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Conversation

Choose a reason for hiding this comment

Codecov Report

2 participants