Home Original page

fix(storage): Add start appendable condition for bypassing full object checksum by v-pratap · Pull Request #15786 · googleapis/google-cloud-cpp

@v-pratap

We are getting checksum mismatch error for few of the appendable uploads, this condition was missing. We need to add this condition since full object checksum is not available for fastbyte objects.
image

@v-pratap

@gemini-code-assist

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@v-pratap

@codecov

@scotthart

gemini-code-assist[bot]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a checksum mismatch error occurring during appendable uploads. The fix involves adding a condition to correctly identify appendable uploads when finalizing a write, ensuring that the full object checksum is bypassed as it's not available for these types of objects. The change is logical and directly addresses the described problem. I have one minor suggestion to improve code readability.

bajajneha27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we please add a testcase too?

@v-pratap

bajajneha27

scotthart