Home Original page

Reproduction of issue 4133 by bbakerman · Pull Request #4142 · graphql-java/graphql-java

Conversation

@bbakerman

This is a reproduction of #4133 and I can confirm it does assert

graphql.AssertException: type Inventory not found in schema

	at graphql.Assert.throwAssert(Assert.java:223)
	at graphql.Assert.assertNotNull(Assert.java:53)
	at graphql.schema.GraphQLTypeResolvingVisitor.handleTypeReference(GraphQLTypeResolvingVisitor.java:49)
	at graphql.schema.GraphQLTypeResolvingVisitor.visitGraphQLTypeReference(GraphQLTypeResolvingVisitor.java:44)
	at graphql.schema.GraphQLTypeReference.accept(GraphQLTypeReference.java:62)
	at graphql.schema.SchemaTraverser$TraverserDelegateVisitor.enter(SchemaTraverser.java:111)
	at graphql.util.Traverser.traverse(Traverser.java:144)
	at graphql.schema.SchemaTraverser.doTraverse(SchemaTraverser.java:98)
	at graphql.schema.SchemaTraverser.depthFirst(SchemaTraverser.java:88)
	at graphql.schema.SchemaTraverser.depthFirst(SchemaTraverser.java:81)
	at graphql.schema.impl.SchemaUtil.replaceTypeReferences(SchemaUtil.java:105)
	at graphql.schema.GraphQLSchema$Builder.buildImpl(GraphQLSchema.java:873)
	at graphql.schema.GraphQLSchema$Builder.build(GraphQLSchema.java:841)
	at graphql.schema.SchemaTransformer$DummyRoot.rebuildSchema(SchemaTransformer.java:631)
	at graphql.schema.SchemaTransformer.transformImpl(SchemaTransformer.java:161)
	at graphql.schema.SchemaTransformer.transform(SchemaTransformer.java:120)
	at graphql.schema.SchemaTransformer.transformSchema(SchemaTransformer.java:88)
	at graphql.schema.SchemaTransformerTest.issue 4133 reproduction(SchemaTransformerTest.groovy:1080)

I havent looked why but it does

@github-actions

Test Results

  325 files    325 suites   5m 0s ⏱️
5 203 tests 5 193 ✅ 9 💤 1 ❌
5 292 runs  5 282 ✅ 9 💤 1 ❌

For more details on these failures, see this check.

Results for commit c839bf7.

@github-actions

Test Results

  325 files    325 suites   5m 5s ⏱️
5 203 tests 5 194 ✅ 8 💤 1 ❌
5 292 runs  5 283 ✅ 8 💤 1 ❌

For more details on these failures, see this check.

Results for commit c839bf7.

@github-actions

Test Results

  325 files    325 suites   5m 5s ⏱️
5 203 tests 5 195 ✅ 8 💤 0 ❌
5 292 runs  5 284 ✅ 8 💤 0 ❌

Results for commit aacdc39.

♻️ This comment has been updated with latest results.

andimarek

"""

def schema = TestUtil.schema(sdl)
schema = schema.transform { builder ->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the test pass because now every type will be always visited

Labels

2 participants

@bbakerman @andimarek